You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just getting familiar with the code base. I see that the flake has a lot going on, and there's a good number of anti-patterns so this is really just a cleanup PR.
Solution
Use writeShellApplication instead of custom wrapper type mkTask. mkTask is essentially trying to do what writeShellApplication already does, without the added benefit of running shellcheck.
Organize derivations and overlays for better composability, and less likelihood of getting or incorrectly setting policy decisions used by downstream consumers.
Add legacyPackages and apps for package introspection from the repl and discoverability.
Add the default package to checks for convenience.
Checks
By submitting this for review, I'm confirming I've done the following:
made this PR as small as possible
unit-tested any new functionality
linked any relevant issues or PRs
included screenshots (if this involves a front-end change)
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: dd972926-53b6-46e7-8e47-8253a281d92f
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
🔍 Trigger review
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
If mkTask is used a lot downstream, to avoid breaking things we could change the function such that the inputs stay the same, but the actual returned value is writeShellApplication and using it prints a deprecation warning. That would make it a bit easier to eventually adopt the right pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Just getting familiar with the code base. I see that the flake has a lot going on, and there's a good number of anti-patterns so this is really just a cleanup PR.
Solution
Use
writeShellApplicationinstead of custom wrapper typemkTask.mkTaskis essentially trying to do whatwriteShellApplicationalready does, without the added benefit of running shellcheck.Organize derivations and overlays for better composability, and less likelihood of getting or incorrectly setting policy decisions used by downstream consumers.
Add
legacyPackagesandappsfor package introspection from the repl and discoverability.Add the default package to
checksfor convenience.Checks
By submitting this for review, I'm confirming I've done the following: