Skip to content

chore: Organize flake#113

Draft
eureka-cpu wants to merge 1 commit intorainlanguage:mainfrom
eureka-cpu:eureka-cpu/0
Draft

chore: Organize flake#113
eureka-cpu wants to merge 1 commit intorainlanguage:mainfrom
eureka-cpu:eureka-cpu/0

Conversation

@eureka-cpu
Copy link
Copy Markdown

@eureka-cpu eureka-cpu commented Apr 7, 2026

Motivation

Just getting familiar with the code base. I see that the flake has a lot going on, and there's a good number of anti-patterns so this is really just a cleanup PR.

Solution

Use writeShellApplication instead of custom wrapper type mkTask. mkTask is essentially trying to do what writeShellApplication already does, without the added benefit of running shellcheck.

Organize derivations and overlays for better composability, and less likelihood of getting or incorrectly setting policy decisions used by downstream consumers.

Add legacyPackages and apps for package introspection from the repl and discoverability.

Add the default package to checks for convenience.

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dd972926-53b6-46e7-8e47-8253a281d92f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eureka-cpu
Copy link
Copy Markdown
Author

If mkTask is used a lot downstream, to avoid breaking things we could change the function such that the inputs stay the same, but the actual returned value is writeShellApplication and using it prints a deprecation warning. That would make it a bit easier to eventually adopt the right pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant