-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Data] Add BackpressurePolicy to streaming executor progress bar #59637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the streaming executor's progress bar by displaying the names of the backpressure policies that are currently active. The changes are well-implemented across the physical operator interface and the streaming executor state management. The addition of new tests ensures the correctness of this new feature. I have one suggestion to improve the code by using dataclasses.field(default_factory=list) for initializing mutable default values, which is a more idiomatic approach.
python/ray/data/_internal/execution/streaming_executor_state.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/execution/streaming_executor_state.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/execution/streaming_executor_state.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/execution/streaming_executor_state.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/execution/streaming_executor_state.py
Outdated
Show resolved
Hide resolved
python/ray/data/_internal/execution/streaming_executor_state.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Srinath Krishnamachari <[email protected]>
52798cc to
472de06
Compare
Signed-off-by: Srinath Krishnamachari <[email protected]>
python/ray/data/_internal/execution/backpressure_policy/backpressure_policy.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Srinath Krishnamachari <[email protected]>
python/ray/data/_internal/execution/backpressure_policy/backpressure_policy.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Srinath Krishnamachari <[email protected]>
Description
[Data] Add BackpressurePolicy to streaming executor progress bar
Add Backpressure policy information to streaming executor progress bar
Related issues
Additional information