TDK-10018 : Enhance Cryptography Interface tests#307
Open
Abhishek-0412 wants to merge 1 commit intordkcentral:masterfrom
Open
TDK-10018 : Enhance Cryptography Interface tests#307Abhishek-0412 wants to merge 1 commit intordkcentral:masterfrom
Abhishek-0412 wants to merge 1 commit intordkcentral:masterfrom
Conversation
MFransen69
approved these changes
Jan 13, 2026
|
This PR is opened from long time, can you please check and close it Please let us know if there is any support needed. |
There was a problem hiding this comment.
Pull request overview
This PR updates the cryptography interface test runner to avoid silently falling back to the Netflix vault instance when a specific vault instance was explicitly requested via command-line options, making instance-selection behavior more deterministic in cgfacetests.
Changes:
- Track whether a vault instance flag was provided (
--netflix,--default,--platform,--testdefaultinstance). - Only fall back to
CRYPTOGRAPHY_VAULT_NETFLIXwhen no instance-selection flag was supplied.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For cgfacetests -
Source code - Source/cryptography/tests/cryptography_test/InterfaceTests.cpp
There is provision to test for different vault instances - using command line options
-netflix
--default
--platform
--testdefaultinstance
However if the test fails to obtain the provided instance, the error is not captured and test proceeds to obtain CRYPTOGRAPHY_VAULT_NETFLIX.
Handled this by setting a flag incase command line option is provided