fix: fix popup flicker issue when inline menus have benn collased#664
Open
ohhoney1 wants to merge 3 commits intoreact-component:masterfrom
Open
fix: fix popup flicker issue when inline menus have benn collased#664ohhoney1 wants to merge 3 commits intoreact-component:masterfrom
ohhoney1 wants to merge 3 commits intoreact-component:masterfrom
Conversation
Member
|
能用例覆盖到吗? |
Author
抱歉忘记重跑一次用例了。本地有个用例没过： #578 这个 pr 新增的用例。我再看看，是否再加条用例 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
很久的一个历史问题了，antd 官方和本仓库demo都可复现。解析 Submenu 里的 items 时，如果存在嵌套 Submenu ，就出现此问题，即存在第三层 menu 的样式问题。
解决方案：考虑在inline模式下非折叠时，不设置 motion 动画。
相关 issue ：ant-design/pro-components#7607 (comment) ，这个gif 同样问题。
相关 pr：