Skip to content

fix(locale): add Romanian time column labels - #1019

Open
vicuts wants to merge 1 commit into
react-component:masterfrom
vicuts:fix/locale-ro-ro-time-labels
Open

vicuts wants to merge 1 commit into
react-component:masterfrom
vicuts:fix/locale-ro-ro-time-labels

Conversation

@vicuts

@vicuts vicuts commented Oct 10, 2026 •

Copy link
Copy Markdown

Summary

  • add hourSelect, minuteSelect, secondSelect, millisecondSelect and meridiemSelect to ro_RO
  • change timeSelect from selectează timpul to selectează ora
  • add a focused locale regression in tests/locale-ro-ro.spec.ts

Since #987 the time columns use these keys as the aria-label of each listbox. ro_RO does not define them, so it inherits the English defaults from commonLocale. A screen reader then announces "Select an hour" inside an otherwise Romanian picker.

The new labels follow the casing of the same keys in en_US and use the verb already used by dateSelect. The meridiem label says AM/PM because that is what the column shows for Romanian: neither the Day.js nor the Moment ro locale defines its own meridiem.

In timeSelect, "timp" means time as a duration (or the weather), not the time of day. Romanian uses "ora" for that, which also matches the antd ro_RO TimePicker placeholder Selectează ora. The existing lowercase style of timeSelect and dateSelect is kept. hourSelect and timeSelect share the word "ora" because Romanian uses it for both "the hour" and "the time".

#1015 also edits ro_RO.ts, but it only appends calendarFallback after nextCentury. A local git merge-tree against its head merges ro_RO.ts cleanly.

Verification

  • The new test fails on master (received Select an hour and selectează timpul) and passes with this change
  • npm test: 17 suites passed, 507 tests passed, 2 skipped, 29 snapshots passed
  • npm run tsc and npm run lint:tsc
  • npm run lint: 0 errors, 16 existing hook warnings
  • prettier --check src/locale/ro_RO.ts tests/locale-ro-ro.spec.ts
  • git diff --check

Summary by CodeRabbit

  • 本地化
    • 更新罗马尼亚语时间选择文案,并补充小时、分钟、秒、毫秒及 AM/PM 的选择标签,使时间选择界面显示更完整。

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ba54c6e5-bbd8-40c1-9b56-762b61f09f6c

📥 Commits

Reviewing files that changed from the base of the PR and between 97fbf8a and 56f22b2.


📒 Files selected for processing (2)
  • src/locale/ro_RO.ts
  • tests/locale-ro-ro.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



Walkthrough

罗马尼亚语区域更新了时间选择文案,并增加小时、分钟、秒、毫秒和 AM/PM 标签。新增测试验证这些文案。

Changes

罗马尼亚语时间标签

Layer / File(s) Summary
时间标签与测试
src/locale/ro_RO.ts, tests/locale-ro-ro.spec.ts
timeSelect 文案改为“selectează ora”。新增小时、分钟、秒、毫秒和 AM/PM 标签,并添加测试断言。

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 56f22

The Romanian time-column labels are covered by the locale regression test; no actionable merge risk was found.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed 标题准确概括了主要变更:为罗马尼亚语 locale 添加时间列标签。标题简洁、明确,并与代码和测试变更一致。
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR

🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.



Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

我是兔子,蹦到钟表旁,
看见小时标签亮闪闪。
分钟、秒和毫秒排成行,
AM/PM 也有了新衣裳。
罗马尼亚语文案读起来真清爽,
我竖起耳朵,欢快地跳一场!

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Oct 10, 2026

Copy link
Copy Markdown

@vicuts is attempting to deploy a commit to the afc163's projects Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant