Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Walkthrough罗马尼亚语区域更新了时间选择文案,并增加小时、分钟、秒、毫秒和 AM/PM 标签。新增测试验证这些文案。 Changes罗马尼亚语时间标签
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The Romanian time-column labels are covered by the locale regression test; no actionable merge risk was found. Pre-merge checks |
|
|
@vicuts is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
Summary
hourSelect,minuteSelect,secondSelect,millisecondSelectandmeridiemSelecttoro_ROtimeSelectfromselectează timpultoselectează oratests/locale-ro-ro.spec.tsSince #987 the time columns use these keys as the
aria-labelof eachlistbox.ro_ROdoes not define them, so it inherits the English defaults fromcommonLocale. A screen reader then announces "Select an hour" inside an otherwise Romanian picker.The new labels follow the casing of the same keys in
en_USand use the verb already used bydateSelect. The meridiem label saysAM/PMbecause that is what the column shows for Romanian: neither the Day.js nor the Momentrolocale defines its own meridiem.In
timeSelect, "timp" means time as a duration (or the weather), not the time of day. Romanian uses "ora" for that, which also matches the antdro_ROTimePicker placeholderSelectează ora. The existing lowercase style oftimeSelectanddateSelectis kept.hourSelectandtimeSelectshare the word "ora" because Romanian uses it for both "the hour" and "the time".#1015 also edits
ro_RO.ts, but it only appendscalendarFallbackafternextCentury. A localgit merge-treeagainst its head mergesro_RO.tscleanly.Verification
master(receivedSelect an hourandselectează timpul) and passes with this changenpm test: 17 suites passed, 507 tests passed, 2 skipped, 29 snapshots passednpm run tscandnpm run lint:tscnpm run lint: 0 errors, 16 existing hook warningsprettier --check src/locale/ro_RO.ts tests/locale-ro-ro.spec.tsgit diff --checkSummary by CodeRabbit