chore: update maintenance dependencies#985
Conversation
|
Deployment failed with the following error: Learn More: https://vercel.com/react-component?upgradeToPro=build-rate-limit |
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Code Review
This pull request upgrades the project's dependencies to support React 19, ESLint 9, and TypeScript 6, introducing a flat ESLint configuration, Dependabot grouping, and compatibility type definitions. Key feedback highlights that disabling strict TypeScript compiler flags and declaring testing globals as any significantly reduces type safety. Additionally, overriding global React module declarations in a non-published file may cause compilation errors for consumers, and the ESLint configuration should robustly handle array-based recommended configs to avoid silently disabling rules. Finally, redundant type casting in tests should be refactored for better readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| allConfig: js.configs.all, | ||
| }); | ||
|
|
||
| const recommendedTsRules = new Set(Object.keys(tsEslintPlugin.configs.recommended.rules || {})); |
There was a problem hiding this comment.
In @typescript-eslint/eslint-plugin v8 (and ESLint flat config), configs.recommended can be an array of config objects rather than a single object. If it is an array, tsEslintPlugin.configs.recommended.rules will be undefined, resulting in an empty recommendedTsRules set and silently disabling all recommended TypeScript linting rules. We should handle both array and object structures to ensure rules are correctly extracted.
const recommendedRulesObj = Array.isArray(tsEslintPlugin.configs.recommended) ? tsEslintPlugin.configs.recommended.reduce((acc, config) => ({ ...acc, ...config.rules }), {}) : tsEslintPlugin.configs.recommended?.rules || {};
const recommendedTsRules = new Set(Object.keys(recommendedRulesObj));| "noImplicitAny": false, | ||
| "strictNullChecks": false, | ||
| "strictPropertyInitialization": false, | ||
| "strictFunctionTypes": false, | ||
| "strict": false, | ||
| "noImplicitThis": false, | ||
| "strictBindCallApply": false |
There was a problem hiding this comment.
Disabling strict type-checking flags (such as strict, strictNullChecks, noImplicitAny, etc.) significantly reduces type safety and can easily introduce runtime errors (e.g., Cannot read properties of undefined). It is highly recommended to keep strict mode enabled, especially for a widely used library like @rc-component/picker, to ensure code quality and robustness.
| declare module 'react' { | ||
| type ReactText = string | number; | ||
| function useRef<T = undefined>(): React.MutableRefObject<T | undefined>; | ||
| function isValidElement<P = any>(object: {} | null | undefined): object is React.ReactElement<P>; | ||
| function cloneElement<P = any>( | ||
| element: React.ReactElement<P>, | ||
| props?: (Partial<P> & React.Attributes) | null, | ||
| ...children: React.ReactNode[] | ||
| ): React.ReactElement<P>; | ||
| } |
There was a problem hiding this comment.
Overriding global module declarations for react in react-compat.d.ts is a fragile workaround. Since this file is not published to npm (not included in package.json files), any references to removed types like ReactText in the generated declaration files (.d.ts) will cause compilation errors for consumers of this package who are using React 19. It is highly recommended to refactor the codebase to avoid using deprecated/removed React types (like ReactText) and to use standard React 19 types directly.
| declare const describe: any; | ||
| declare const it: any; | ||
| declare const test: any; | ||
| declare const beforeEach: any; | ||
| declare const afterEach: any; | ||
| declare const beforeAll: any; | ||
| declare const afterAll: any; | ||
| declare const expect: any; |
There was a problem hiding this comment.
Declaring testing globals (describe, it, test, expect, etc.) as any disables type safety and autocompletion in test files. Since @types/jest is installed as a devDependency, these globals should be typed properly (either automatically via tsconfig.json types or by importing them/referencing the correct types) rather than using any.
✅ Preview is ready!
↩️ Previous: ⚡️ 🤖 Powered by surge-preview |
|||||||||||||||
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #985 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 66 66
Lines 2698 2698
Branches 749 724 -25
=======================================
Hits 2666 2666
Misses 29 29
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Deployment failed with the following error: Learn More: https://vercel.com/afc163s-projects?upgradeToPro=build-rate-limit |

Summary
Test Plan