Repository navigation
fix: excavate modules behind image in fallback rendering mode - #183
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
|
@feritcemkahraman is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
imageSettings.excavateistrue,cellsToDrawis calculated with excavated modules cleared in the region behind the embedded image. In the Path2D rendering path,cellsToDrawis used. However, in the fallback rendering branch (isSupportPath2d === false), the loop iterated over unexcavatedcellsinstead ofcellsToDraw, resulting in unexcavated modules being painted behind the image.Changes
src/QRCodeCanvas.tsx:cellsToDraw.forEach(...)instead ofcells.forEach(...)in the non-Path2D fallback branch.tests/fallback.test.tsxverifying that modules behind the embedded image are properly excavated when Path2D is unsupported.