Use umbrella instead of a direct include in jsinspector-modern/tracing module (#58552) - #58552
Open
j-piasecki wants to merge 4 commits into
Open
j-piasecki wants to merge 4 commits into
j-piasecki wants to merge 4 commits into
Conversation
j-piasecki
force-pushed
the
export-D120313623
branch
from
September 16, 2026 08:35
acb1376 to
f4c5621
Compare
meta-cla
Bot
added
the
CLA Signed
j-piasecki
force-pushed
the
export-D120313623
branch
2 times, most recently
from
September 16, 2026 12:44
a814f2c to
39e48e2
Compare
j-piasecki
force-pushed
the
export-D120313623
branch
from
September 16, 2026 12:49
39e48e2 to
9f9a348
Compare
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120313623. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…g module (react#58552) Summary: Changelog: [Internal] Update the jsinspector-modern/tracing module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120313623
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…g module (react#58552) Summary: Changelog: [Internal] Update the jsinspector-modern/tracing module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120313623
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 16, 2026
…g module (react#58552) Summary: Pull Request resolved: react#58552 Changelog: [Internal] Update the jsinspector-modern/tracing module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120313623
j-piasecki
force-pushed
the
export-D120313623
branch
from
September 16, 2026 12:58
9f9a348 to
4a294a2
Compare
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 21, 2026
…g module (react#58552) Summary: Changelog: [Internal] Update the jsinspector-modern/tracing module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120313623
j-piasecki
force-pushed
the
export-D120313623
branch
from
September 21, 2026 06:43
4a294a2 to
ba674b7
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 22, 2026
…g module (react#58552) Summary: Changelog: [Internal] Update the jsinspector-modern/tracing module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120313623
j-piasecki
force-pushed
the
export-D120313623
branch
from
September 22, 2026 13:14
ba674b7 to
56ef650
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 22, 2026
…g module (react#58552) Summary: Changelog: [Internal] Update the jsinspector-modern/tracing module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120313623
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 22, 2026
…g module (react#58552) Summary: Changelog: [Internal] Update the jsinspector-modern/tracing module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120313623
Summary: Each module ships a small header that acts as its entry point. Those were being packaged into the React framework, but the code that includes them lives in the shared headers bundle the framework is built on top of. The two ended up pointing at each other and the iOS build failed. Ship the entry-point headers with the shared headers instead. They still resolve the same way for anyone including them, and no other header moves. Changelog: [Internal] Differential Revision: D121187558
Summary: Changelog: [Internal] Update the timing module to use `React/Debug.h` umbrella include instead of a direct one. Reviewed By: cipolleschi Differential Revision: D120137164
…g module (react#58552) Summary: Changelog: [Internal] Update the jsinspector-modern/tracing module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120313623
j-piasecki
force-pushed
the
export-D120313623
branch
from
September 22, 2026 14:38
56ef650 to
f1a9867
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Update the jsinspector-modern/tracing module to use
React/Timing.humbrella include instead of a direct one.Differential Revision: D120313623