Use global DOM types in Fantom tests (#58569) - #58569
Closed
rubennorte wants to merge 2 commits into
Closed
rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120528709. |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 17, 2026
Summary: Pull Request resolved: react#58569 Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through `dispatchNativeEvent`. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D120528709
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D120528709
branch
from
September 17, 2026 16:00
588ad72 to
830b34d
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 17, 2026
Summary: Pull Request resolved: react#58569 Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through `dispatchNativeEvent`. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D120528709
rubennorte
force-pushed
the
export-D120528709
branch
2 times, most recently
from
September 17, 2026 16:24
3d66020 to
e3c90e9
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 17, 2026
Summary: Pull Request resolved: react#58569 Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through `dispatchNativeEvent`. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D120528709
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Pull Request resolved: react#58569 Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through `dispatchNativeEvent`. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D120528709
rubennorte
force-pushed
the
export-D120528709
branch
from
September 18, 2026 10:58
e3c90e9 to
8c62373
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Pull Request resolved: react#58569 Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through `dispatchNativeEvent`. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D120528709
rubennorte
force-pushed
the
export-D120528709
branch
from
September 18, 2026 11:05
8c62373 to
f9b049b
Compare
Summary: Replace eligible React Native deep imports in Fantom tests with package exports, Fantom APIs, DOM globals, and types derived from exported symbols. Keep implementation-specific imports where the public surface does not expose equivalent behavior or compatible Flow types. Changelog: [Internal] Differential Revision: D120517166
rubennorte
force-pushed
the
export-D120528709
branch
from
September 18, 2026 11:31
f9b049b to
b9c9177
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Pull Request resolved: react#58569 Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through `dispatchNativeEvent`. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D120528709
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Pull Request resolved: react#58569 Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through `dispatchNativeEvent`. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D120528709
rubennorte
force-pushed
the
export-D120528709
branch
from
September 18, 2026 11:37
b9c9177 to
0089c9f
Compare
Summary: Pull Request resolved: react#58569 Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through `dispatchNativeEvent`. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D120528709
rubennorte
force-pushed
the
export-D120528709
branch
from
September 18, 2026 11:44
0089c9f to
1a942a4
Compare
|
This pull request has been merged in 652d501. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through
dispatchNativeEvent.Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D120528709