Conversation
meta-cla
Bot
added
the
CLA Signed
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120528333. |
facebook-github-tools
Bot
added
p: Software Mansion
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 17, 2026
Summary: Pull Request resolved: react#58570 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the modal module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120528333
coado
force-pushed
the
export-D120528333
branch
from
September 17, 2026 16:13
72659c7 to
64aea43
Compare
meta-codesync
Bot
changed the title
Summary: Update Fabric component codegen to consume the public View module through <React/View.h> for generated props, event emitters, shadow nodes, and dimension conversions. Refresh generated snapshots and checked-in popup-menu bindings, and add strict consumer compile coverage that does not use RN_BUILDING. Make the View umbrella compatible with force-CXX platform configurations discovered by the broader generated-header coverage. On Android, gate the ViewPropsInterpolation rawProps workaround on both ANDROID and RN_SERIALIZABLE_STATE, since rawProps only exists when serializable state is enabled; this preserves existing Android behavior without enabling the runtime/ABI feature globally. For Android, macOS, and Windows platform types, rely on the Buck-selected HostPlatformViewProps and HostPlatformViewEventEmitter headers instead of compiler platform macros: the native implementations already expose NativeDrawable, HostPlatformViewEvents, KeyEvent, MouseEvent, and WindowsViewEvents, while force-CXX builds intentionally do not export those platform-only headers. Changelog: [Internal]. Reviewed By: cipolleschi Differential Revision: D119490247
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the modal module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120528333
coado
force-pushed
the
export-D120528333
branch
from
September 18, 2026 11:17
64aea43 to
a5456cb
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the modal module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120528333
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the modal module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120528333
cortinico
approved these changes
Sep 18, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the modal module with strict API enforcement enabled.
Changelog: [Internal]
Differential Revision: D120528333