Conversation
- Dockerfile: use npm ci --omit=dev instead of copy-all + npm prune - Add shared wildcard TLS cert for staging previews instead of per-PR certs - Fix PVC cleanup label selector in cd.yml (was using wrong label) - Change PDB maxUnavailable from 0 to 1 to stop blocking node drains - Make integrity check non-blocking by dropping yield* on runFork Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Add spans to all 20 Discord SDK wrappers (discord.fetchGuild, discord.sendMessage, etc.) - Add top-level command dispatch span (command.<name>) wrapping all interaction handlers - Add per-attempt child spans to audit log retry loop - Replace ConsoleSpanExporter with DevTreeSpanExporter for readable timing trees in dev - Make Sentry tracesSampleRate configurable via SENTRY_TRACES_SAMPLE_RATE env var Co-Authored-By: Claude Opus 4.6 <[email protected]>
Adds spans to fetchSettingsEffect and constructLog which were missing instrumentation, and refactors raw Discord API calls in the alreadyReported branch of userLog.ts to use our instrumented Effect wrappers (fetchMessage, messageReply, sendMessage) so they appear in trace trees. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Smoke Test Results
Tested commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Effect.withSpanon Discord SDK calls, commands, audit log fetches, and settings queriesSENTRY_TRACES_SAMPLE_RATEenv varnpm ci --omit=dev, shared wildcard TLS cert for previews, correct PVC cleanup label, PDB allows node drainsTest plan
cluster/preview/certificate.yamlto cluster before next preview deploy🤖 Generated with Claude Code