Refactoring related to ReactPy v2.0.0#54
Open
shawncrawley wants to merge 2 commits intoreactive-python:mainfrom
Open
Refactoring related to ReactPy v2.0.0#54shawncrawley wants to merge 2 commits intoreactive-python:mainfrom
shawncrawley wants to merge 2 commits intoreactive-python:mainfrom
Conversation
Author
|
When I run the test suite locally, I still have one test failing that I couldn't figure out how to fix: reactpy-router/tests/test_router.py Line 52 in 898c8fd It is failing with: I used various AI searches and did a lot of digging to find out how that could have ever worked and thus hopefully discover the required refactor, but unfortunately my searching came up empty. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is my attempt to update reactpy-router to work with the ReactPy v2.0 pre-release package.
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).