Skip to content

fix: harden admin runtime correctness and recovery - #60

Closed
sunnylqm wants to merge 5 commits into
mainfrom
fix/runtime-correctness-20260831
Closed

fix: harden admin runtime correctness and recovery#60
sunnylqm wants to merge 5 commits into
mainfrom
fix/runtime-correctness-20260831

Conversation

@sunnylqm

@sunnylqm sunnylqm commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • tolerate nullable Redis-backed quota and PV statistics in the admin user drawer
  • show a retryable error state when the admin identity query fails instead of spinning forever
  • stop create/update/delete mutations from synthesizing incomplete or empty app caches; refetch canonical data instead
  • treat custom API endpoint changes as an authentication boundary by clearing the old session, workspace, and query cache before reload
  • canonicalize endpoint URLs and allow plain HTTP only for local development
  • bound the service-worker runtime cache and retry stale chunks once per UI build
  • rank distribution-chart legends by cumulative request count rather than equal-weight daily percentages
  • format daily distribution tooltips as dates without a meaningless 00:00

Tests added

  • app mutation cache updater behavior
  • custom endpoint URL normalization
  • per-build chunk recovery guard
  • distribution ranking under unequal daily traffic
  • daily tooltip time formatting

Deliberately not changed

The HttpOnly cookie login/logout rollout and credential transport are not modified in this PR.

Validation

CI will run typecheck, Biome, Bun tests, production build, and bundle-size checks.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Treat Redis-backed user metrics as nullable, render missing values as dashes, and replace the admin-route infinite spinner with an explicit retry state.
Keep missing list/detail caches undefined, refetch canonical app data after create/update/delete, and cover the cache updater behavior with unit tests.
Canonicalize custom endpoints, clear credentials/workspace/cache before switching servers, bound the service-worker cache, and allow one stale-chunk reload per UI build.
Select default legend categories from cumulative request counts rather than equal-weight daily percentages, and format daily chart tooltips without a meaningless midnight time.
@netlify

netlify Bot commented Aug 31, 2026

Copy link
Copy Markdown

Deploy Preview for pushy ready!

Name Link
🔨 Latest commit 96ee9a0
🔍 Latest deploy log https://app.netlify.com/projects/pushy/deploys/6a94fd21bcc0eb0008c35459
😎 Deploy Preview https://deploy-preview-60--pushy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Apply the formatter output reported by CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant