Skip to content

Conversation

@akhilnittala
Copy link
Contributor

@akhilnittala akhilnittala commented Jan 27, 2026

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
When both sso and oidc config is provided in argocd, we are not rejecting the request. so with this pr changes, we have implemented validation which rejects the request with argocd CR having both sso and oidc configuration.
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-8560
Fixes #?
https://issues.redhat.com/browse/GITOPS-8560
Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

  • install argocd operator with changes
  • create argo cd CR with both sso and oidc config
  • request should be rejected.

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Jan 27, 2026
@akhilnittala akhilnittala force-pushed the usr/akhil/GITOPS-8560_ValidationMarkerChanges branch from b509227 to 5e4244f Compare January 27, 2026 08:46
@svghadi
Copy link
Member

svghadi commented Jan 27, 2026

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akhilnittala
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2026

@akhilnittala: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential 5e4244f link true /test v4.14-kuttl-sequential
ci/prow/v4.19-kuttl-sequential 5e4244f link true /test v4.19-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants