Skip to content

Test fix: Update argocd and helm versions in validate_toolchain test - #1281

Merged
svghadi merged 2 commits into
redhat-developer:v1.21from
varshab1210:update-toolchain
Sep 10, 2026
Merged

Test fix: Update argocd and helm versions in validate_toolchain test#1281
svghadi merged 2 commits into
redhat-developer:v1.21from
varshab1210:update-toolchain

Conversation

@varshab1210

Copy link
Copy Markdown
Member

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:

Updated helm and argocd version changes with 1.21.4 release

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Varsha B <vab@vab-thinkpadp1gen4i.rmtin.csb>
@openshift-ci openshift-ci Bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Sep 7, 2026
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: edde9a5b-dd46-4940-9936-53c285719960

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@svghadi

svghadi commented Sep 7, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved and removed lgtm labels Sep 7, 2026
@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

Signed-off-by: Varsha B <vab@vab-thinkpadp1gen4i.rmtin.csb>
@varshab1210

Copy link
Copy Markdown
Member Author

/test v4.21-e2e

@svghadi

svghadi commented Sep 10, 2026

Copy link
Copy Markdown
Member

Error: controllers/argocd/argocd.go:249:4: SA1019: (github.com/argoproj-labs/argocd-operator/api/v1beta1.ArgoCDSpec).Grafana is deprecated: Grafana defines the Grafana server options for ArgoCD. (staticcheck)
Grafana: getArgoGrafanaSpec(),

static check failure is already fixed in 1.21 branch:

Grafana: getArgoGrafanaSpec(), //nolint:staticcheck // SA1019: Grafana is deprecated but still supported

Force merging inorder to avoid unnecessary CI runs again.

@svghadi
svghadi merged commit ac3371e into redhat-developer:v1.21 Sep 10, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved kind/failing-test Categorizes issue or PR as related to a frequently failing test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants