feat(i18n): migrate browser simple value editors to i18n (RI-8274) - #6289
feat(i18n): migrate browser simple value editors to i18n (RI-8274)#6289valkirilov wants to merge 12 commits into
Conversation
Code Coverage - Frontend unit tests
Test suite run success7879 tests passing in 870 suites. Report generated by 🧪jest coverage report action from d42e108 |
03efa32 to
57d59b3
Compare
f8d91cb to
d22cd5d
Compare
57d59b3 to
7ea5928
Compare
d22cd5d to
1587baf
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1587baface
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
1587baf to
2756b2b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2756b2b2ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code Coverage - Backend unit tests
Test suite run success3721 tests passing in 322 suites. Report generated by 🧪jest coverage report action from d42e108 |
…ia labels (RI-8274)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92ff2ee1b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4cd2a0fad0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1bf6a0c338
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a709dc09b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code Coverage - Integration Tests
|
…estination keys (RI-8274)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a46c476. Configure here.
2 participants
Summary
Routes all user-facing strings in the hash, set, sorted-set, list, string and ReJSON value editors through
t()with flatbrowser.<type>.*keys, filled in bothen.jsonandbg.json(Bulgarian).Commits (one per type)
<Trans>remove-popover (count-pluralElement(s)+ "removed from the tail/head of key"), Index/Element columns. Converted the sharedoptionsDestinations("Push to tail/head") to agetPushDestinations(t)factory and updated its other consumerAddKeyListso its select is translated too.browser.keyDetails.editable.*confirm keys from PR B.JSONErrors→ParseKeysmap, JSON key/value placeholders, add/edit/apply/cancel aria, Monaco Close/Overwrite Data, duplicate-key overwrite popover, copy/download actions.Note
Low Risk
Display-string and test assertion updates only; Redis write flows and confirmation logic are unchanged aside from translated copy.
Overview
Moves hash, list, set, sorted set, string, and ReJSON browser key-detail UIs off hard-coded English onto
useTranslation/t(), with matchingbrowser.*keys inen.jsonandbg.json(pluralized production-write confirms, list remove popover via<Trans>, sharedbrowser.keyDetails.*tooltips/errors).Supporting refactors: add-key field configs become
getAdd*FormConfig(t)factories; list push destinations usegetPushDestinations(t)(also wired from add-key list); ReJSONJSONErrorsnow holds i18n key paths; specs assert translated error text viai18n.t.CI: UI type-check step sets
NODE_OPTIONS=--max-old-space-size=8192sotscdoes not OOM as the locale key union grows.Reviewed by Cursor Bugbot for commit d42e108. Bugbot is set up for automated code reviews on this repo. Configure here.