Conversation
|
|
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| {{ end }} | ||
| {{- .Inner | markdownify -}} | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Duplicated alert partial instead of parameterizing icon
Low Severity
alert-video.html is a near-exact copy of alert.html, differing only in the icon partial (Youtube.html vs alert-circle.html). All other shortcodes (note, warning, tip, info) share the single alert.html partial. Any future styling or structural change to the alert component now needs to be applied to both partials independently, risking divergence. The existing alert.html partial could instead accept an optional icon parameter.
mich-elle-luna
left a comment
mich-elle-luna
left a comment
There was a problem hiding this comment.
It doesn't appear on the page as an alert yet.
| {{< video-link >}} | ||
| See [Connect to Redis Cloud with AWS PrivateLink](https://www.youtube.com/watch?v=i3aTmcyFihY) for a short video tutorial on how to connect to Redis Cloud with AWS PrivateLink. | ||
| {{< /video-link >}} | ||
|
|
There was a problem hiding this comment.
When I build your fork, I can see the text of the alert but not the box or icon, so maybe it needs to be changed to reflect the name 'video' ? Thank you.
There was a problem hiding this comment.
I created the video-link shortcode because there is already a video shortcode, which looks like it embeds a video into the page instead of a callout to a video link.
The icon should appear if you have the video-link shortcode and the alert-video partial
There was a problem hiding this comment.
I don't see a commit in here with something called video-link, are you able to build it locally and view the alert box?
There was a problem hiding this comment.
@mich-elle-luna I took a fresh checkout of this PR, ran make all then make serve and I see it:
There was a problem hiding this comment.
Thank you! I rebuilt and see it now, much appreciated.
| {{< video-link >}} | ||
| See [Connect to Redis Cloud with AWS PrivateLink](https://www.youtube.com/watch?v=i3aTmcyFihY) for a short video tutorial on how to connect to Redis Cloud with AWS PrivateLink. | ||
| {{< /video-link >}} | ||
|
|
There was a problem hiding this comment.
I don't see a commit in here with something called video-link, are you able to build it locally and view the alert box?
| {{< video-link >}} | ||
| See [Connect to Redis Cloud with AWS PrivateLink](https://www.youtube.com/watch?v=i3aTmcyFihY) for a short video tutorial on how to connect to Redis Cloud with AWS PrivateLink. | ||
| {{< /video-link >}} | ||
|
|
There was a problem hiding this comment.
Thank you! I rebuilt and see it now, much appreciated.
4 participants
added video-link shortcode
*Update content/operate/rc/security/aws-privatelink.md
Note
Low Risk
Low risk documentation/UI templating change that adds a new shortcode and partial; no runtime business logic or data handling is affected.
Overview
Adds a new
video-linkHugo shortcode that renders a styled “Video” callout using a newcomponents/alert-video.htmlpartial with a YouTube icon.Updates the AWS PrivateLink docs (
content/operate/rc/security/aws-privatelink.md) to wrap a YouTube tutorial link in this new shortcode so it displays as a highlighted video alert.Written by Cursor Bugbot for commit 4a8c69f. This will update automatically on new commits. Configure here.