Conversation
masad-frost
approved these changes
Feb 3, 2026
Member
masad-frost
left a comment
There was a problem hiding this comment.
Looks good to me, but probably best to wait for Ryan's stamp
ryantm
approved these changes
Feb 3, 2026
Co-authored-by: Ryan Mulligan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bun was using a custom override (
pkgs/bun/default.nix) to pin a specific version downloaded from GitHub releases. This is unnecessary sincenixpkgsalready provides up-to-date Bun packages.What changed
Deleted
pkgs/bun/default.nixRemoved the custom override that pinned Bun to
1.2.16.Updated
pkgs/modules/bun/default.nixChanged to a curried function pattern (
{ bun }:) to acceptbunas a parameter, matching Node.js and PostgreSQL modules.Updated
pkgs/modules/default.nixNow passes
pkgs.bunexplicitly to the Bun module.Updated
pkgs/modules/nodejs/default.nixChanged
pkgs.callPackage ../../bun { }topkgs.bun.Added
bun-1.2topkgs/historical-modules/default.nixPinned to commit
a3a6925withdisplayVersion = 1.2.16for backwards compatibility.Updated
pkgs/upgrade-map/default.nixAdded upgrade chain:
bun-1.0 → bun-1.1 → bun-1.2 → bun-1.3Test plan