Repository navigation
fix: pin the guide compiler and validate lesson output - #1439
Open
fhammerschmidt wants to merge 3 commits into
Open
fhammerschmidt wants to merge 3 commits into
fhammerschmidt wants to merge 3 commits into
Conversation
Pin browser compilation and lesson validation to ReScript v12.3.1. Compile each starter and reference solution during prerendering, then compare its runtime output with the checkpoint using the shared guide transformations. Keep reference solutions out of published lesson data, fail builds on compiler CDN errors, and show stalled browser compiler loading with a reload message. Add real compiler validation and browser failure coverage. Fixes rescript-lang#1405. Part of rescript-lang#1421.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Use common compiler endpoint configuration and console serialization so the guide compiler pin and lesson validator stay compatible with the playground refactor in rescript-lang#1441. Keep this PR independently buildable before rescript-lang#1441 is merged. Fixes rescript-lang#1405. Part of rescript-lang#1421.
Keep validation failures fatal while allowing the shared compiler loader refactor in rescript-lang#1441 to merge cleanly. Part of rescript-lang#1421.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guide previously selected the newest stable compiler on the CDN during each build. Lessons were never compiled or checked against their expected output, and a failed versions download could publish the guide without a compiler.
Pin the guide to ReScript v12.3.1 and validate lessons during prerendering:
exercise.solutionCode, defaulting to the starter. The function lesson supplies a reference solution while retaining the original exercise for learners.Targets website
master(v12). No compiler repository changes.Validation:
Fixes #1405.
Part of #1421.