Drop module variant es6 and es6-global completely
#8130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
reviewed
Dec 30, 2025
| let lib_commonjs = lib_lit // "js" | ||
|
|
||
| let lib_es6_global = lib_lit // "es6_global" | ||
| let lib_esmodule = lib_lit // "es6" |
Member
There was a problem hiding this comment.
Suggested change
| let lib_esmodule = lib_lit // "es6" | |
| let lib_esmodule = lib_lit // "esmodule" |
Member
Author
There was a problem hiding this comment.
It's for the output path "lib/es6"
If we change this then it will be another breaking change which is huge
Member
There was a problem hiding this comment.
Ah, right. It does look wrong/confusing though. Maybe leave the name lib_es6 and/or add a comment why we do not change this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es6andes6-globalwere deprecated in favor ofesmodulein #6709We're printing the deprecation message for it. And it's good to go, as we announced in the CHANGELOG and the config documentation.