Skip to content

Improve deprecated attribute extraction and support record form#8396

Merged
cknitt merged 4 commits intorescript-lang:masterfrom
aspeddro:tools-deprecated-record
Apr 28, 2026
Merged

Improve deprecated attribute extraction and support record form#8396
cknitt merged 4 commits intorescript-lang:masterfrom
aspeddro:tools-deprecated-record

Conversation

@aspeddro
Copy link
Copy Markdown
Contributor

@aspeddro aspeddro commented Apr 27, 2026

  • Enhance findDeprecatedAttribute to extract the reason from record-form @deprecated attributes.
  • Ensure deprecated attribute extraction works regardless of attribute order by reversing the list in newDeclared.
  • Update tests and expected outputs to reflect improved deprecated reason extraction, including record-form deprecations.

@aspeddro
improve deprecated attribute extraction and support record form
826438a 
- Enhance `findDeprecatedAttribute` to extract the `reason` from record-form `@deprecated` attributes.
- Ensure deprecated attribute extraction works regardless of attribute order by reversing the list in `newDeclared`.
- Update tests and expected outputs to reflect improved deprecated reason extraction, including record-form deprecations.
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 27, 2026 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8396

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8396

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8396

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8396

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8396

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8396

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8396

commit: fbd54d5

@aspeddro aspeddro changed the title improve deprecated attribute extraction and support record form Improve deprecated attribute extraction and support record form Apr 28, 2026
@aspeddro aspeddro marked this pull request as ready for review April 28, 2026 01:40
cknitt
cknitt approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@cknitt cknitt enabled auto-merge (squash) April 28, 2026 17:15
@cknitt cknitt merged commit afe06dd into rescript-lang:master Apr 28, 2026
25 checks passed
@aspeddro aspeddro mentioned this pull request Apr 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cknitt cknitt cknitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aspeddro @cknitt