Repository navigation
Conversation
Set_ident, Set_int and Set_string are Set.Make instances with the same comparisons; Ext_set and Set_gen are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christoph Knittel <ck@cca.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
added this pull request to stack #8788
October 10, 2026 18:56
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christoph Knittel <ck@cca.io>
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of four PRs moving the compiler's own collections onto the OCaml standard library, stacked on #8787. This one covers sets.
Set_ident,Set_intandSet_stringare nowSet.Makeinstances with the same comparison functions, includingExt_string.compare(length first) for strings, so iteration order is unchanged. Call sites use the stdlib argument order (Set_ident.add x s,Set_ident.mem x s,Set_ident.iter f s, …). Element and set types always differ, so the type checker verifies every flipped call.Ext_setandSet_genare removed, together with the ounit tests of their balanced-tree invariants.Output: byte-identical to #8787 on 628 files (Belt, all of
tests/tests/src, and the benchmark stress inputs).Performance: neutral (CPU −0.6%, allocation +0.35% vs master).
🤖 Generated with Claude Code