VSCode Electron - #210
Closed
mrjackv wants to merge 6 commits into
Closed
Conversation
mrjackv
force-pushed
the
feature/vscode-electron
branch
from
July 21, 2026 08:26
c59af8d to
c46234e
Compare
aleclearmind
left a comment
aleclearmind
left a comment
Contributor
There was a problem hiding this comment.
NOTETOSELF: review the last commit after I review the revng-ui extension.
mrjackv
force-pushed
the
feature/vscode-electron
branch
2 times, most recently
from
August 3, 2026 10:53
67850b8 to
b8f5468
Compare
aleclearmind
reviewed
Aug 3, 2026
mrjackv
force-pushed
the
feature/vscode-electron
branch
2 times, most recently
from
August 4, 2026 08:49
a788376 to
11ea9d4
Compare
The `static-npm-registry` program is a python script, so python is required as a dependency.
Upgrade nodejs to version 22.22.3, upgrading all its depencies as well.
Also improve build times by using `lld` and exclude some additional tests that now fail when run in the CI.
The component `vscode-web` is now built using `npm` instead of `yarn`. Update the build script to account for that and improve the `nodejs-support` scripts to handle a project with so many dependencies.
mrjackv
force-pushed
the
feature/vscode-electron
branch
from
August 4, 2026 09:34
11ea9d4 to
99a9ce1
Compare
Change the following: * The script for building the vsix has changed from `package` to `package-web`. * The configuration format has changed, adapt the `configurationDefaults` to account for it.
Introduce the electron-flavoured version of `revng-vscode-web`. It's an electron build of vscode with the revng extension pre-installed. This commit introduces 3 new components: * `vscode-electron`: build plain vscode with electron * `revng-ui-native-extension`: native build of revng-ui. It differs to the `revng-ui-web` variant due to additional dependencies for native usage (e.g. connecting to unix sockets) * `revng-ui-native`: just like `revng-vscode-web` this is just the previous two components merged in the right way to make a standalone installation with everything For naming consistency the following components have also been renamed: * `revng-ui` -> `revng-ui-web-extension` * `revng-vscode-web` -> `revng-ui-web` This commit also adds `revng-ui-native` to the `revng-development` component so that it will be built when the CI runs with the default target.
mrjackv
force-pushed
the
feature/vscode-electron
branch
from
August 4, 2026 09:47
99a9ce1 to
f63ab01
Compare
Contributor
|
Merged in c285f29. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.