feat: 'impl Clone' and inner-error access for TracedError#1
Merged
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
BatmanAoD
force-pushed
the
pr-1055-traced-error-err-into
branch
from
ddd8a61 to
acbbf51
Compare
BatmanAoD
force-pushed
the
traced-error-improvements
branch
2 times, most recently
from
dab96a0 to
e6c1bbf
Compare
BatmanAoD
force-pushed
the
pr-1055-traced-error-err-into
branch
from
acbbf51 to
635c708
Compare
BatmanAoD
force-pushed
the
traced-error-improvements
branch
from
e6c1bbf to
3b3df65
Compare
BatmanAoD
force-pushed
the
pr-1055-traced-error-err-into
branch
from
a2cd246 to
979cc0e
Compare
BatmanAoD
force-pushed
the
traced-error-improvements
branch
2 times, most recently
from
6230cfc to
ef87fd7
Compare
BatmanAoD
force-pushed
the
pr-1055-traced-error-err-into
branch
from
979cc0e to
ade769c
Compare
BatmanAoD
force-pushed
the
traced-error-improvements
branch
from
ef87fd7 to
0729770
Compare
BatmanAoD
changed the base branch from
pr-1055-traced-error-err-into
to
rigetti-only-pr-3555
This change makes TracedError a two-way door, making it easier to adopt in a larger codebase. This change provides an "escape hatch" to be able to read and extract error stored within a TracedError. Among other things, this will help adoption of TracedError by: * allowing onboarding users to still match against error variants, as might be common in test cases * allowing crate users to bypass missing or unreleased features * allowing for partial migration of a codebase, so that TracedError can be used in one portion, and then the original error extracted at some interface above which TracedError is not yet used or wanted.
BatmanAoD
force-pushed
the
traced-error-improvements
branch
from
0729770 to
fb8f983
Compare
jselig-rigetti
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our "local" version of tokio-rs#3556.
Remainder of motivation and solution copied from kalzoo#1
Motivation
This change makes TracedError a two-way door, making it easier to adopt in a larger codebase.
This change provides an "escape hatch" to be able to read and
extract error stored within a TracedError. Among other things,
this will help adoption of TracedError by:
allowing onboarding users to still match against error variants,
as might be common in test cases
allowing crate users to bypass missing or unreleased features
allowing for partial migration of a codebase, so that TracedError
can be used in one portion, and then the original error extracted
at some interface above which TracedError is not yet used or wanted.
Solution
Add
TracedError::get_inner_errorto get a ref, andTracedError::to_inner_errorto unwrap it entirely