Repository navigation
Convert some sleep-heavy tests to synctest - #1406
Merged
Merged
Conversation
I just happened to notice that the LLMs are starting to use `synctest` in test cases, so I asked Codex to go back and try to convert any test cases that look like low hanging fruit for `synctest` because they're heavily reliant on sleeps. We get some nice individual speedups: | Test group | Before | After | |---|---:|---:| | Debounce | 252.7 ms | 0.8 ms | | Notification limiter | 200.8 ms | 1.4 ms | | Completion/shutdown | 1,233.3 ms | 0.9 ms | | Periodic job registry | 572.1 ms | 1.9 ms | | Cancellable sleep | 52.6 ms | 0.7 ms | | Ticker | 1.8 ms | 0.8 ms | Everything runs in parallel so there's no meaningful speed up overall, but it can't hurt to have some individual tests that get faster.
Contributor
Author
|
@bgentry Gonna merge this since it's test only and probably not harmful, but LMK if you have any objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just happened to notice that the LLMs are starting to use
synctestin test cases, so I asked Codex to go back and try to convert any test
cases that look like low hanging fruit for
synctestbecause they'reheavily reliant on sleeps. We get some nice individual speedups:
Everything runs in parallel so there's no meaningful speed up overall,
but it can't hurt to have some individual tests that get faster.