Repository navigation
docs: a non-running job's cancel emits no job_cancelled - #1485
Merged
brandur merged 2 commits intoOct 9, 2026
Merged
Conversation
Client.JobCancel on a job that isn't running (available, scheduled, retryable) finalizes it in the database and emits no event: subscribers only see cancellations of jobs a client was working. Say so on the event kind, and point at the JobRow JobCancel returns. Signed-off-by: Jack Danger <github@jackcanty.com>
JackDanger
force-pushed
the
docs/job-cancelled-event-scope
branch
from
October 9, 2026 04:59
8f84674 to
7077e9c
Compare
brandur
approved these changes
Oct 9, 2026
brandur
marked this pull request as ready for review
October 9, 2026 22:39
Contributor
|
@JackDanger I tweaked the wording a tiny bit here, but yep, looks good to me. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventKindJobCancelledsays it occurs "when a job is cancelled", but events flow from the completer: cancelling an available/scheduled/retryable job finalizes it in the database without an event.Says so on the event kind; points at the
JobRowJobCancelreturns.Found by the river-rs differential verifier.