Use a specific message for end-of-file parse errors#5613
Merged
Conversation
rmosolgo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oops, this case of parser error message started giving the wrong debug info after 88d6c1c.
It was because
@scanner.matched_size.nil?was now true/false in slightly different circumstances, depending on whether the query had comments or ignored characters in it.I tried to preserve compatibility as-is, but it didn't seem like the right move. Instead, I'm adding a specific end-of-file debug message in this case, like GraphQL-CParser already has.