Skip to content

Comments

fix(snapshotter): add withLogo support and Android bounds parity#4154

Merged
mfazekas merged 2 commits intornmapbox:mainfrom
jackashton:fix/snapshotter-with-logo-and-bounds
Feb 22, 2026
Merged

fix(snapshotter): add withLogo support and Android bounds parity#4154
mfazekas merged 2 commits intornmapbox:mainfrom
jackashton:fix/snapshotter-with-logo-and-bounds

Conversation

@jackashton
Copy link
Contributor

@jackashton jackashton commented Feb 17, 2026

Summary

  • Add withLogo option support to iOS and Android snapshot modules
  • Add bounds support to Android to match existing iOS implementation

Problem

The withLogo option exists in TypeScript types but was ignored by native code. The bounds option worked on iOS but not Android.

Solution

iOS: Set mapSnapshotOptions.showsLogo from the withLogo option

Android:

  • Pass SnapshotOverlayOptions(showLogo) to Snapshotter
  • Add bounds support via snapshotter.cameraForCoordinates()

Test Plan

  • Updated TakeSnapshot example to demonstrate:

    • withLogo: true (shows logo)
    • withLogo: false (hides logo)
    • bounds option (alternative to centerCoordinate)
  • iOS tested

  • Android tested

@jackashton jackashton temporarily deployed to CI with Mapbox Tokens February 17, 2026 02:35 — with GitHub Actions Inactive
@jackashton jackashton temporarily deployed to CI with Mapbox Tokens February 17, 2026 02:35 — with GitHub Actions Inactive
@jackashton jackashton temporarily deployed to CI with Mapbox Tokens February 17, 2026 02:35 — with GitHub Actions Inactive
@jackashton jackashton changed the title feat(snapshotter): add withLogo support and Android bounds parity fix(snapshotter): add withLogo support and Android bounds parity Feb 17, 2026
@jackashton jackashton temporarily deployed to CI with Mapbox Tokens February 22, 2026 05:36 — with GitHub Actions Inactive
@jackashton jackashton temporarily deployed to CI with Mapbox Tokens February 22, 2026 05:36 — with GitHub Actions Inactive
@jackashton jackashton temporarily deployed to CI with Mapbox Tokens February 22, 2026 05:36 — with GitHub Actions Inactive
@mfazekas mfazekas merged commit 93ae675 into rnmapbox:main Feb 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants