[hist] Test Python interface of core classes #21054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the exact bin edges.
hahnjo
requested review from
guitargeek,
hageboeck,
jblomer,
siliataider and
vepadulano
hageboeck
reviewed
Jan 28, 2026
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
Looks good already, but I had a few questions regarding the interface.
Test Results 22 files 22 suites 3d 20h 52m 37s ⏱️ Results for commit e7b18f5. ♻️ This comment has been updated with latest results. |
hageboeck
approved these changes
Jan 28, 2026
vepadulano
approved these changes
Jan 29, 2026
siliataider
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construction from a list of axes will currently print a confusing error:
This is harmless since the
std::vectoroverload is chosen afterwards, see #21053.