[tutorials][test] Specify the include path for SOFIE tutorials in CMake #21056
+19
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
tutorials_env
branch
from
dbac4e6 to
88edd4f
Compare
Test Results 22 files 22 suites 3d 14h 50m 2s ⏱️ For more details on these failures, see this check. Results for commit 173f8b0. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Jan 28, 2026
pcanal
reviewed
Jan 28, 2026
guitargeek
force-pushed
the
tutorials_env
branch
4 times, most recently
from
dd3eddf to
5966926
Compare
We don't want to rely on environment variables like `ROOTSYS` in the tutorials, and we should also not leak details of the test setup like `$ROOTSYS/runtutorials` in the user-facing tutorials.
guitargeek
force-pushed
the
tutorials_env
branch
from
5966926 to
173f8b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to rely on environment variables like
ROOTSYSin the tutorials, and we should also not leak details of the test setup like$ROOTSYS/runtutorialsin the user-facing tutorials.To make tutorial environment variables also work on Windows when they include paths with multiple elements, the first commit avoids the use of the
ENVIRONMENTargument for the ROOT test macros, because it doesn't support multiple path elements on Windows.This is a spinoff of #21018.