[gui] Simplify ROOTSYS handling in TGFSComboBox#21069
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Jan 29, 2026
Merged
[gui] Simplify ROOTSYS handling in TGFSComboBox#21069guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
In `TGFSComboBox.cxx`, the logic to figure out ROOTSYS is duplicating what is already done in TROOT. We can just use `gROOT->GetRootSys()` to reuse that logic.
Test Results 22 files 22 suites 3d 17h 12m 49s ⏱️ Results for commit fccf0ed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
TGFSComboBox.cxx, the logic to figure out ROOTSYS is duplicating what is already done in TROOT. We can just usegROOT->GetRootSys()to reuse that logic.Spinoff from #21018.