Skip to content

Comments

[build] Use CMAKE_INSTALL_<dir> variables consistently in setup.py#21075

Merged
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:setup_py
Jan 30, 2026
Merged

[build] Use CMAKE_INSTALL_<dir> variables consistently in setup.py#21075
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:setup_py

Conversation

@guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Jan 30, 2026

This ensures that the subdirectories of the install tree are not moved relative to each other after the install step.

Spinoff from #21018

@guitargeek guitargeek requested a review from vepadulano January 30, 2026 07:58
@guitargeek guitargeek self-assigned this Jan 30, 2026
@guitargeek guitargeek requested a review from dpiparo as a code owner January 30, 2026 07:58
@guitargeek guitargeek added the build-python-wheels Run the workflow to build Python wheels label Jan 30, 2026
This ensures that the subdirectories of the install tree are not moved
relative to each other after the install step.
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions
Copy link

Test Results

    22 files      22 suites   3d 17h 32m 31s ⏱️
 3 775 tests  3 774 ✅ 0 💤 1 ❌
75 079 runs  75 071 ✅ 7 💤 1 ❌

For more details on these failures, see this check.

Results for commit 7d49340.

@guitargeek guitargeek merged commit 2233979 into root-project:master Jan 30, 2026
34 of 36 checks passed
@guitargeek guitargeek deleted the setup_py branch January 30, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-python-wheels Run the workflow to build Python wheels in:Build System

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants