Remove workaround for TASImage::DrawCircle - #23130
Open
linev wants to merge 3 commits into
Open
Conversation
Problem was fixed before in TASImage class
As for all other engines use template definition
Markers now shown as filled circle - making PNG size larger
Test Results 23 files 23 suites 3d 16h 38m 18s ⏱️ For more details on these failures, see this check. Results for commit da7b666. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After problem #23014 with TASImage was fixed one can remove workaround and draw circle markers as circle.
Adjust ref file - while PNG size is slightly different in contrast of filled polygon