Skip to content

Use tl_expected from libexpected-dev instead (backport #572)#580

Merged
christophfroehlich merged 3 commits intohumblefrom
mergify/bp/humble/pr-572
Mar 26, 2026
Merged

Use tl_expected from libexpected-dev instead (backport #572)#580
christophfroehlich merged 3 commits intohumblefrom
mergify/bp/humble/pr-572

Conversation

@mergify
Copy link

@mergify mergify bot commented Mar 26, 2026

Needs PickNikRobotics/generate_parameter_library#322


This is an automatic backport of pull request #572 done by Mergify.

(cherry picked from commit 88f5298)

# Conflicts:
#	.github/workflows/rolling-semi-binary-build-win.yml
#	package.xml
@mergify mergify bot added the conflicts label Mar 26, 2026
@mergify
Copy link
Author

mergify bot commented Mar 26, 2026

Cherry-pick of 88f5298 has failed:

On branch mergify/bp/humble/pr-572
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 88f5298.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   include/control_filters/custom_validators.hpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/rolling-semi-binary-build-win.yml
	both modified:   package.xml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.46%. Comparing base (33efe18) to head (cf7e88e).
⚠️ Report is 2 commits behind head on humble.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble     #580   +/-   ##
=======================================
  Coverage   59.46%   59.46%           
=======================================
  Files          28       28           
  Lines        1453     1453           
  Branches      807      806    -1     
=======================================
  Hits          864      864           
  Misses        233      233           
  Partials      356      356           
Flag Coverage Δ
unittests 59.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit aa2ea79 into humble Mar 26, 2026
12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-572 branch March 26, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants