Skip to content

Use tl_expected from libexpected-dev instead (backport #572)#582

Merged
christophfroehlich merged 2 commits intokiltedfrom
mergify/bp/kilted/pr-572
Mar 26, 2026
Merged

Use tl_expected from libexpected-dev instead (backport #572)#582
christophfroehlich merged 2 commits intokiltedfrom
mergify/bp/kilted/pr-572

Conversation

@mergify
Copy link

@mergify mergify bot commented Mar 26, 2026

Needs PickNikRobotics/generate_parameter_library#322


This is an automatic backport of pull request #572 done by Mergify.

(cherry picked from commit 88f5298)

# Conflicts:
#	.github/workflows/rolling-semi-binary-build-win.yml
@mergify
Copy link
Author

mergify bot commented Mar 26, 2026

Cherry-pick of 88f5298 has failed:

On branch mergify/bp/kilted/pr-572
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit 88f5298.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   control_toolbox/include/control_filters/custom_validators.hpp
	modified:   control_toolbox/package.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/rolling-semi-binary-build-win.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.74%. Comparing base (4363a0b) to head (5995a38).
⚠️ Report is 2 commits behind head on kilted.

Additional details and impacted files
@@           Coverage Diff           @@
##           kilted     #582   +/-   ##
=======================================
  Coverage   82.74%   82.74%           
=======================================
  Files          29       29           
  Lines        1999     1999           
  Branches      110      110           
=======================================
  Hits         1654     1654           
  Misses        276      276           
  Partials       69       69           
Flag Coverage Δ
unittests 82.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 9520ce0 into kilted Mar 26, 2026
12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-572 branch March 26, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants