feat: Add per-node log level support via NodeOptions#3092
Open
penww wants to merge 1 commit intoros2:rollingfrom
Open
feat: Add per-node log level support via NodeOptions#3092penww wants to merge 1 commit intoros2:rollingfrom
penww wants to merge 1 commit intoros2:rollingfrom
Conversation
dbb1e05 to
4fad28c
Compare
Author
|
@alsora could you help to review this PR? |
Add a log_level option to NodeOptions that allows setting the initial log severity for a node at construction time, enabling per-component log level customization in component containers. Signed-off-by: Peng Wang <penwang@qti.qualcomm.com>
Author
|
It seems CI failed by other code, could you help to re-run CI? @jmachowinski --- stderr: rclcpp
/opt/ros2_ws/src/ros2/rclcpp/rclcpp/src/rclcpp/subscription_base.cpp: In member function ‘bool rclcpp::SubscriptionBase::is_cft_supported() const’:
/opt/ros2_ws/src/ros2/rclcpp/rclcpp/src/rclcpp/subscription_base.cpp:486:10: error: ‘rcl_subscription_is_cft_supported’ was not declared in this scope; did you mean ‘rcl_subscription_is_cft_enabled’?
486 | return rcl_subscription_is_cft_supported(subscription_handle_.get());
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| rcl_subscription_is_cft_enabled
gmake[2]: *** [CMakeFiles/rclcpp.dir/build.make:1292: CMakeFiles/rclcpp.dir/src/rclcpp/subscription_base.cpp.o] Error 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a log_level option to NodeOptions that allows setting the initial log severity for a node at construction time, enabling per-component log level customization in component containers.
Description
Fixes (#3091)
User could set log level for single node and component.
Is this user-facing behavior change?
No, the additional log level option is optional and default back to the current behavior.
Did you use Generative AI?
Partially with Claude Sonnet 4.6
Additional Information
Look at: #3091