Improve error message when parameter value is missing#3093
Open
yadnyeshwar wants to merge 3 commits intoros2:rollingfrom
Open
Improve error message when parameter value is missing#3093yadnyeshwar wants to merge 3 commits intoros2:rollingfrom
yadnyeshwar wants to merge 3 commits intoros2:rollingfrom
Conversation
fujitatomoya
requested changes
Mar 12, 2026
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
although i think current message is fine enough, i guess that is okay to change the exception message as suggested.
can you also address https://build.ros2.org/job/Rpr__rclcpp__ubuntu_noble_amd64/919/?
Signed-off-by: yadnyeshwar <yadnyeshwarasakhare@gmail.com>
yadnyeshwar
force-pushed
the
improve-parameter-error-message
branch
from
6f5c173 to
5bf6790
Compare
Signed-off-by: yadnyeshwar <yadnyeshwarasakhare@gmail.com>
Signed-off-by: yadnyeshwar <yadnyeshwarasakhare@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the error message thrown when a parameter value is missing during parameter value conversion in
parameter_map.cpp.Previously, the exception message was:
This message did not clearly indicate the source of the problem.
The updated message clarifies that the issue originates from the underlying
rclparameter structure when no value is present.This improves debugging and provides clearer feedback when invalid parameter configurations are encountered.
Fixes # (issue)
Is this user-facing behavior change?
Yes.
The error message shown when a parameter value is missing has been made more descriptive to improve debugging and clarity for users.
Did you use Generative AI?
No.
Additional Information
This change only updates the exception message and does not modify any logic or behavior in parameter parsing.