Skip to content

COMN-423: Use parent POM 26.0.0 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seth-mg merged 4 commits into from
Feb 11, 2026
Merged

COMN-423: Use parent POM 26.0.0 #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d90b51
COMN-422: Specify annotation processors
juliencherry Jan 12, 2026
e09b6be
COMN-422: Replace deprecated Square JavaPoet with Palantir JavaPoet
juliencherry Jan 12, 2026
17b905c
COMN-423: Use parent POM 26.0.0
juliencherry Feb 2, 2026
f664ff0
COMN-422: javapoet must be compile scope now
seth-mg Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions annotations/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright 2017-2024 Basis Technology Corp.
Copyright 2017-2026 Babel Street Rosette Ltd.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -28,18 +28,15 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.squareup</groupId>
<groupId>com.palantir.javapoet</groupId>
Copy link
Contributor

@seth-mg seth-mg Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite what their README says, this is still likely provided scope, right? I imagine it's usage is limited to pre-compilation.

Copy link
Collaborator Author

@juliencherry juliencherry Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to need to be compile scope. Otherwise, the build fails:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.1:compile (default-compile) on project rosette-api-model: Fatal error compiling: java.lang.NoClassDefFoundError: com/palantir/javapoet/TypeSpec: com.palantir.javapoet.TypeSpec -> [Help 1]

Copy link
Contributor

@seth-mg seth-mg Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I should have tried it first. 🤦‍♂️

<artifactId>javapoet</artifactId>
<version>${java-poet.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.projectlombok</groupId>
Expand Down
12 changes: 6 additions & 6 deletions annotations/src/main/java/com/basistech/rosette/annotations/JacksonMixinProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2022 Basis Technology Corp.
* Copyright 2026 Babel Street Rosette Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -21,11 +21,11 @@
import com.fasterxml.jackson.databind.Module;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import com.fasterxml.jackson.databind.annotation.JsonPOJOBuilder;
import com.squareup.javapoet.AnnotationSpec;
import com.squareup.javapoet.CodeBlock;
import com.squareup.javapoet.JavaFile;
import com.squareup.javapoet.MethodSpec;
import com.squareup.javapoet.TypeSpec;
import com.palantir.javapoet.AnnotationSpec;
import com.palantir.javapoet.CodeBlock;
import com.palantir.javapoet.JavaFile;
import com.palantir.javapoet.MethodSpec;
import com.palantir.javapoet.TypeSpec;
import lombok.Builder;

import javax.annotation.processing.AbstractProcessor;
Expand Down
58 changes: 35 additions & 23 deletions model/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright 2017-2022 Basis Technology Corp.
Copyright 2017-2026 Babel Street Rosette Ltd.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -53,12 +53,6 @@
<version>${lombok.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.squareup</groupId>
<artifactId>javapoet</artifactId>
<version>${java-poet.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
Expand All @@ -78,6 +72,40 @@
</dependencies>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<annotationProcessorPaths>
<path>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>${lombok.version}</version>
</path>
<path>
<groupId>com.basistech.rosette</groupId>
<artifactId>rosette-api-annotations</artifactId>
<version>${project.version}</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven-javadoc-plugin.version}</version>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
<configuration>
<sourcepath>${delombok.output.directory}</sourcepath>
</configuration>
</plugin>
<plugin>
<groupId>org.projectlombok</groupId>
<artifactId>lombok-maven-plugin</artifactId>
Expand Down Expand Up @@ -108,22 +136,6 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven-javadoc-plugin.version}</version>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
<configuration>
<sourcepath>${delombok.output.directory}</sourcepath>
</configuration>
</plugin>
</plugins>
</build>
</project>
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright 2018-2024 Basis Technology Corp.
Copyright 2018-2026 Babel Street Rosette Ltd.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -23,7 +23,7 @@
<parent>
<artifactId>open-source-parent</artifactId>
<groupId>com.basistech</groupId>
<version>25.0.0</version>
<version>26.0.0</version>
<relativePath />
</parent>
<packaging>pom</packaging>
Expand All @@ -45,7 +45,7 @@
<build-helper-maven-plugin.version>3.6.1</build-helper-maven-plugin.version>
<commons-codec.version>1.20.0</commons-codec.version>
<jakarta-validation-api.version>3.1.1</jakarta-validation-api.version>
<java-poet.version>1.13.0</java-poet.version>
<java-poet.version>0.10.0</java-poet.version>
<junit.version>6.0.1</junit.version>
<lombok.version>1.18.42</lombok.version>
<lombok-maven-plugin.version>1.18.20.0</lombok-maven-plugin.version>
Expand Down