Skip to content

fix: run all merged buildEnd hooks - #109

Merged
ScriptedAlchemy merged 2 commits into
mainfrom
codex/run-all-build-end-hooks
Aug 29, 2026
Merged

fix: run all merged buildEnd hooks#109
ScriptedAlchemy merged 2 commits into
mainfrom
codex/run-all-build-end-hooks

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Collaborator

Follow-up to the unresolved review on #108.

  • run every merged buildEnd hook in deterministic order
  • preserve and rethrow the first normalized failure after remaining hooks finish
  • add a regression test using a real normalized Rsbuild config
  • include a patch changeset

Local verification:

  • pnpm exec rstest run tests/react-router-config.test.ts
  • pnpm typecheck
  • pnpm test:core (640 passed)
  • pnpm format:check
  • pnpm build

@ScriptedAlchemy

Copy link
Copy Markdown
Collaborator Author

@codex review

@pkg-pr-new

pkg-pr-new Bot commented Aug 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/rsbuild-plugin-react-router@16f5987

commit: 16f5987

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Benchmark results

Case Base Head Delta
build-256-ssr 2016.6 ms 2064.6 ms +2.4%
dev-48-ssr 860.1 ms 849.5 ms -1.2%

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: a12e28014b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codspeed-hq

codspeed-hq Bot commented Aug 28, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 1 untouched benchmark
⏩ 2 skipped benchmarks1


Comparing codex/run-all-build-end-hooks (16f5987) with main (ae222a3)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ScriptedAlchemy
ScriptedAlchemy merged commit df208f5 into main Aug 29, 2026
9 of 11 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the codex/run-all-build-end-hooks branch August 29, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant