fix: remove webpack related dependencies and scripts#414
Merged
chenjiahan merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes webpack-related build paths from the rspack examples workspace by dropping webpack scripts/dependencies and deleting the module-federation-interop example packages, with corresponding lockfile updates.
Changes:
- Removed webpack scripts and webpack-only devDependencies from
rspack/nest-alias. - Deleted the entire
rspack/module-federation-interopexample (webpack MF + rspack MF v1/v1.5 interop). - Updated
pnpm-lock.yamlto reflect dependency/workspace graph changes.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rspack/nest-alias/package.json | Removes webpack-specific scripts and devDependencies. |
| rspack/module-federation-interop/webpack-mf/webpack.config.js | Deleted webpack MF config for the interop example. |
| rspack/module-federation-interop/webpack-mf/src/index.js | Deleted webpack MF entrypoint. |
| rspack/module-federation-interop/webpack-mf/src/Component.js | Deleted webpack MF exposed component. |
| rspack/module-federation-interop/webpack-mf/src/bootstrap.js | Deleted webpack MF bootstrap/host rendering. |
| rspack/module-federation-interop/webpack-mf/package.json | Deleted webpack MF package definition/scripts/deps. |
| rspack/module-federation-interop/rspack-mf-v1/src/index.js | Deleted rspack MF v1 entrypoint. |
| rspack/module-federation-interop/rspack-mf-v1/src/Component.js | Deleted rspack MF v1 exposed component. |
| rspack/module-federation-interop/rspack-mf-v1/src/bootstrap.js | Deleted rspack MF v1 bootstrap/host rendering. |
| rspack/module-federation-interop/rspack-mf-v1/rspack.config.js | Deleted rspack MF v1 build config. |
| rspack/module-federation-interop/rspack-mf-v1/package.json | Deleted rspack MF v1 package definition/scripts/deps. |
| rspack/module-federation-interop/rspack-mf-v1.5/src/runtimePlugins/logger.js | Deleted MF1.5 runtime plugin example. |
| rspack/module-federation-interop/rspack-mf-v1.5/src/index.js | Deleted rspack MF v1.5 entrypoint. |
| rspack/module-federation-interop/rspack-mf-v1.5/src/Component.js | Deleted rspack MF v1.5 exposed component. |
| rspack/module-federation-interop/rspack-mf-v1.5/src/bootstrap.js | Deleted rspack MF v1.5 bootstrap/host rendering. |
| rspack/module-federation-interop/rspack-mf-v1.5/rspack.config.js | Deleted rspack MF v1.5 build config. |
| rspack/module-federation-interop/rspack-mf-v1.5/package.json | Deleted rspack MF v1.5 package definition/scripts/deps. |
| rspack/module-federation-interop/README.md | Deleted interop example documentation. |
| rspack/module-federation-interop/package.json | Deleted interop workspace package wrapper. |
| pnpm-lock.yaml | Removes interop importers + drops webpack-related packages; also contains broader resolution changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove webpack related dependencies and scripts