Avoid array allocation in DSL::Parameters#with#2672
Merged
ericproulx merged 1 commit intomasterfrom Apr 6, 2026
Merged
Conversation
Danger ReportNo issues found. |
ericproulx
force-pushed
the
ruby_optimizations
branch
6 times, most recently
from
b2f64ee to
7e295ef
Compare
Member
|
rebase? |
dblock
approved these changes
Apr 6, 2026
ericproulx
force-pushed
the
ruby_optimizations
branch
from
7e295ef to
7883931
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[@group, opts].compact.reduce(&:deep_merge)with@group&.deep_merge(opts) || optswithblock callHash#deep_mergealways returns a Hash)Test plan
bundle exec rspec spec/grape/dsl/parameters_spec.rb— 23 examples, 0 failures🤖 Generated with Claude Code