fix: use tailwind 4.x bg clases with modifiers#265
Merged
stephannv merged 1 commit intoruby-ui:mainfrom May 7, 2025
Merged
Conversation
stephannv
approved these changes
May 7, 2025
Contributor
|
LGTM! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In adopting Ruby UI I noticed that the Table component class names were not being merged correctly, which broke the hover effect.
bg-opacityutilities are removed in Tailwind 4tailwind_mergeno longer supports them:For RubyUI, recent versions of Tailwind and
tailwind_mergeare installed or recommended by default.I noticed that the docs for RubyUI get around this by using a version of tailwind merge that has tailwind 3.x semantics, but I think it would be best to use Tailwind 4 semantics/utilities.