Skip to content

Fix conditional inclusion of stdckdint.h #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darkain wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Fix conditional inclusion of stdckdint.h #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ext/bigdecimal/missing/dtoa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,14 @@
#include <locale.h>
#endif

#if defined(HAVE_STDCKDINT_H) || !defined(__has_include)
#elif __has_include(<stdckdint.h>)
#if !defined(HAVE_STDCKDINT_H)
#if defined(__has_include)
#if __has_include(<stdckdint.h>)
Copy link
Copy Markdown
Member

@tompng tompng Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original empty-if plus elif is not so readable, and there's a room improvement. But triple-nested-if is also not so good.

It's worth merging this as a refactoring even if there's no compilation problem in the original code.
#if cod1 && cond2 && cond3 may be better than tripple-nested-if and also better than empty-if plus elif. What do you think?

Copy link
Copy Markdown
Member

@tompng tompng Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this file dtoa.c is a copy of https://github.com/ruby/ruby/blob/master/missing/dtoa.c. It was recently updated to the latest one.
I don't want to add a difference because updating the file might be difficult in the future.

# define HAVE_STDCKDINT_H 1
#endif
#endif
#endif

#ifdef HAVE_STDCKDINT_H
# include <stdckdint.h>
#endif
Expand Down