Skip to content

JRuby should soon support PTY.spawn #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
byteit101 wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

JRuby should soon support PTY.spawn #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec4c349
JRuby should soon support PTY.spawn
byteit101 Oct 2, 2022
4f01ad2
Skip interrupt with timeout on JRuby
nobu Sep 12, 2026
2f0b18b
Run tests verbosely on JRuby
nobu Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ jobs:
- name: Run test
run: rake # Attempting without 'bundle exec'
timeout-minutes: 3
env:
TESTOPTS: ${{ startsWith(matrix.ruby, 'jruby') && '--verbose=verbose' || '' }}
- id: build
run: |
rake build
Expand Down
5 changes: 2 additions & 3 deletions test/io/console/test_io_console.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ def assert_ctrl(expect, cc, r, w)
w.print cc
w.flush
result = EnvUtil.timeout(3) {r.gets}
assert_not_nil(result)
if result
case cc.chr
when "\C-A".."\C-_"
Expand Down Expand Up @@ -572,7 +573,7 @@ def test_intr
if cc = ctrl["intr"]
assert_ctrl("#{cc.ord}", cc, r, w)
assert_ctrl("#{cc.ord}", cc, r, w)
assert_ctrl("Interrupt", cc, r, w) unless host_os?(/linux/)
assert_ctrl("Interrupt", cc, r, w) unless host_os?(/linux/) or RUBY_ENGINE == "jruby"
end
if cc = ctrl["dsusp"]
assert_ctrl("#{cc.ord}", cc, r, w)
Expand Down Expand Up @@ -631,8 +632,6 @@ def helper
end

def run_pty(src, n = 1)
pend("PTY.spawn cannot control terminal on JRuby") if RUBY_ENGINE == 'jruby'

args = [TestIO_Console::INCLUDE_OPTS, "-rio/console", "-e", src]
args.shift if args.first == "-I" # statically linked
r, w, pid = PTY.spawn(EnvUtil.rubybin, *args)
Expand Down