Repository navigation
Idea: Preserve matchdata in rules #141
Description
Here's part of a rule I just wrote the other day:
stampfile_pattern = %r"^members/(?<email>.*)/\d{2}-(?<step>\w+).timestamp$"
rule stampfile_pattern do |t|
match = stampfile_pattern.match(t.name)
email = match[:email]
step = match[:step]
# ...
endNotice how, after it matches, I have to re-apply the regex inside the rule definition in order to pull out named matchdata.
I was thinking of introducing something like this as an alternative:
stampfile_pattern = %r"^members/(?<email>.*)/\d{2}-(?<step>\w+).timestamp$"
rule stampfile_pattern do |t|
email = t.matchdata[:email]
step = t.matchdata[:step]
# ...
endBefore I dive in, what do you think? And is there another way to accomplish this that I've missed?
Activity
drbrain commentedon Jun 16, 2016
I think this would be a nice addition.
I don't think there's a way to accomplish this without adding the feature to the rule.
I've not used a rule without dependencies, it gets triggered by a separate task that depends on the output (regexp)?
avdi commentedon Jun 16, 2016
Yeah, that's what I was thinking. I feel like it makes sense, since the task object already has the concrete
t.namethat matched, to also have the matchdata.Yep.
avdi commentedon Jun 16, 2016
I've also thought about this:
I.e. adding the ability to substitute in backreferences in the rule source. Currently, rule sources suffer from the same problem as the rule body: if you want to reference regex matchdata, you have to use a lambda as the dependency and re-apply the regex.
yeban commentedon Dec 2, 2016
I stumbled upon this issue looking for how to access
matchdatainside a rule. This would be a great addition, imho.avdi commentedon Dec 2, 2016