Fixing __has_include(<stdckdint.h>) compilation error#16802
Open
darkain wants to merge 1 commit intoruby:masterfrom
Open
Fixing __has_include(<stdckdint.h>) compilation error#16802darkain wants to merge 1 commit intoruby:masterfrom
darkain wants to merge 1 commit intoruby:masterfrom
Conversation
The very thing the conditional for `__has_include` is trying to handle, is causing compilation to break. This file was brought into the ruby/bigdecimal project, and is failing to compile on a platform which doesnt have `__has_include` support in the compiler. Compile log can be found in this comment: ruby/bigdecimal#531 (comment)
Member
|
This should be ported over to bigdecimal and any other libs that might use this file. |
zenspider
approved these changes
Apr 28, 2026
Member
|
What compiler and environment? |
Author
|
@nobu This is on Oracle Linux 7.9 |
Member
|
Thank you. I found that the default compiler on Oracle Linux 7 is gcc 4.8.5, but it is too old. |
Author
|
The specific check in the code that I'm submitting this PR for is explicitly a fix for "old compilers" that wasn't done correctly. Its the only thing that prevents the code from working on these systems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The very thing the conditional for
__has_includeis trying to handle, is causing compilation to break.This file was brought into the ruby/bigdecimal project, and is failing to compile on a platform which doesnt have
__has_includesupport in the compiler.Compile log can be found in this comment:
ruby/bigdecimal#531 (comment)