Skip to content

Fix release date extraction for the current changelog header format #9767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meganemura wants to merge 1 commit into
base: master
Choose a base branch
from
+37 −1
Open

Fix release date extraction for the current changelog header format #9767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/support/build_metadata.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def git_commit_sha

def release_date_for(version, dir:)
changelog = File.expand_path("CHANGELOG-bundler.md", dir)
File.readlines(changelog)[2].scan(/^## #{Regexp.escape(version)} \((.*)\)/).first&.first if File.exist?(changelog)
File.readlines(changelog)[2].scan(/^## #{Regexp.escape(version)} \/ (.*)$/).first&.first if File.exist?(changelog)
end

extend self
Expand Down
36 changes: 36 additions & 0 deletions test/test_build_metadata_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# frozen_string_literal: true

require "tmpdir"
require "bundler"
require_relative "../spec/support/build_metadata"
require_relative "rubygems/helper"

class BuildMetadataGeneratorTest < Test::Unit::TestCase
def test_release_date_for_extracts_the_date_from_the_current_changelog_header_format
Dir.mktmpdir do |dir|
write_changelog(dir, "## 9.9.9 / 2026-08-05")

assert_equal "2026-08-05", Spec::BuildMetadata.send(:release_date_for, "9.9.9", dir: dir)
end
end

def test_release_date_for_returns_nil_when_the_changelog_has_no_entry_for_the_version
Dir.mktmpdir do |dir|
write_changelog(dir, "## 1.0.0 / 2026-01-01")

assert_nil Spec::BuildMetadata.send(:release_date_for, "9.9.9", dir: dir)
end
end

private

def write_changelog(dir, header)
File.write(File.join(dir, "CHANGELOG-bundler.md"), <<~CHANGELOG)
# Changelog

#{header}

### Enhancements:
CHANGELOG
end
end