Improvements for Rails and ActiveRecord Integration

[vasilakisfil]

1. Add validation tests (+ error class in order to pass)
2. Fixed login ticket lifetime bug (maximum_unused_login_ticket_lifetime was not used in login ticket validation)
3. Add remember_me functionality in the core
4. Change how service tickets are generated. Now each service tickets inherits from TicketGrantingTicket
   in a way to imitate activerecord's belongs_to/has_many.
5. Other minor improvements
6. Tested with rubycas-server-rails engine gem and rubycas-server-activerecord gem

[mitfik]

Thanks a lot for your contribution I will take a look on it, before it will happen could you take a look on the Travis CI errors. Because that needs to be fixed before we could merge anything.

Thanks a lot

[vasilakisfil]

Fixed

[vasilakisfil]

I have detached my repo here: https://github.com/vasilakisfil/rubycas-server-core. It's being used on production months now and we will release our Rails CAS engine soon. Many thanks to the initial contributor.

[mitfik]

Are you still interested to contribute in that project? By merging your changes into main repo? Since I started reviewing what you did and I would like to merge few features which you have implemented.

Thanks for answer

[vasilakisfil]

Hi there! Definitely! The reason I detached the repo is that I didn't get any feedback from you and I needed some changes in the master. I be happy if the repo was moved here again instead in my personal profile! The pull request that you are looking to is really old! I have changed many things here https://github.com/vasilakisfil/rubycas-server-core!

I am not sure how we should proceed. I suggest you take a look my fork and I will contact github to re-attach my fork to your repo. Then I will create a new pull request. How does this sound ?

[zuk]

It might be easier to clone the repo again, branch, and then paste in your
new code to overwrite everything in the branch. Then push the branch back
up. Re-attaching a repo that wasn't cloned directly can be tricky. Not sure
GitHub will be able to do that for you.

On Fri, Jan 16, 2015 at 7:49 AM, Filippos Vasilakis <
[email protected]> wrote:

Hi there! Definitely! The reason I detached the repo is that I didn't get
any feedback from you and I needed some changes in the master. I be happy
if the repo was moved here again instead in my personal profile! The pull
request that you are looking to is really old! I have changed many things
here https://github.com/vasilakisfil/rubycas-server-core!

I am not sure how we should proceed. I suggest you take a look my fork and
I will contact github to re-attach my fork to your repo. Then I will create
a new pull request. How does this sound ?

—
Reply to this email directly or view it on GitHub
#23 (comment)
.

[vasilakisfil]

The branch was forked using github, detached after a request and now it's re-attached. I will create a new pull-request later today.

[vasilakisfil]

I am closing this PR as the code is too old. We can continue on #25