Skip to content

Add message format checking#152276

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
JonathanBrouwer:fmt-check
Feb 9, 2026
Merged

Add message format checking#152276
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
JonathanBrouwer:fmt-check

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Checks the indentation of diagnostic messages, it checks that everything is at least as indented as the attribute that contains it

r? @jdonszelmann (Anyone else, also feel free to review, just assigning to Jana because she's been reviewing the other PRs)

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the F-explicit_tail_calls `#![feature(explicit_tail_calls)]` label Feb 7, 2026
@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review February 8, 2026 09:31
@rustbot

rustbot commented Feb 8, 2026

Copy link
Copy Markdown
Collaborator

rustc_macros::diagnostics was changed

cc @davidtwco, @TaKO8Ki

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 8, 2026
Open
8 tasks
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Feb 8, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer

JonathanBrouwer commented Feb 8, 2026

Copy link
Copy Markdown
Contributor Author

Don't merge together with #152356, these will soft-conflict

@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 8, 2026
Merged
jdonszelmann
jdonszelmann reviewed Feb 9, 2026
View reviewed changes
Comment thread compiler/rustc_mir_build/src/errors.rs
@jdonszelmann

jdonszelmann commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

ok I like this, @bors r+ rollup

@rust-bors

rust-bors Bot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 99c6009 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026
@jhpratt jhpratt mentioned this pull request Feb 9, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Feb 9, 2026
@bors
Auto merge of #152382 - jhpratt:rollup-DIUVWuF, r=jhpratt
71dc761 
Rollup of 3 pull requests

Successful merges:

 - #152357 (std: Don't panic when removing a nonexistent UEFI var)
 - #152180 (Port `rustc_reservation_impl` to the new attribute parser)
 - #152276 (Add message format checking)
@rust-bors rust-bors Bot merged commit 9d31498 into rust-lang:main Feb 9, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Feb 9, 2026
@rust-timer
Unrolled build for #152276
2e636b0 
Rollup merge of #152276 - JonathanBrouwer:fmt-check, r=jdonszelmann

Add message format checking

Checks the indentation of diagnostic messages, it checks that everything is at least as indented as the attribute that contains it

r? @jdonszelmann (Anyone else, also feel free to review, just assigning to Jana because she's been reviewing the other PRs)
@rustbot rustbot added this to the 1.95.0 milestone Feb 9, 2026
@WaffleLapkin WaffleLapkin removed the F-explicit_tail_calls `#![feature(explicit_tail_calls)]` label Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdonszelmann jdonszelmann jdonszelmann left review comments

Assignees

@jdonszelmann jdonszelmann

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer @rust-log-analyzer @rustbot @jdonszelmann @WaffleLapkin