resolve: Introduce `(Local,Extern)Module` newtypes for local and external modules respectively by petrochenkov · Pull Request #155242 · rust-lang/rust

petrochenkov · 2026-04-13T12:59:46Z

Right now both LocalModule and ExternModule refer to the same ModuleData, but the module data for local and extern modules can potentially be made quite different, and we can specialize name lookup for both cases as an optimization.

Declaration creation for local and external modules was already specialized as a part of the parallel import resolution work (see define_local and define_extern, #145108 and previous PRs), because they have different properties with regards to ownership and synchronization.

rustbot · 2026-04-13T12:59:55Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 12 candidates

petrochenkov · 2026-04-13T13:00:16Z

@bors try @rust-timer queue

resolve: Introduce `(Local,Extern)Module` newtypes for local and external modules respectively

rust-bors · 2026-04-13T15:10:07Z

☀️ Try build successful (CI)
Build commit: 64fb35f (64fb35fbcee90871be9b0d2edc78438c95622fdf, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

rust-timer · 2026-04-13T15:50:33Z

Finished benchmarking commit (64fb35f): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary 5.1%, secondary 9.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	8.8%	[4.8%, 11.4%]	6
Regressions ❌ (secondary)	15.8%	[4.8%, 26.9%]	2
Improvements ✅ (primary)	-2.2%	[-2.8%, -1.5%]	3
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	5.1%	[-2.8%, 11.4%]	9

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 491.114s -> 489.595s (-0.31%)
Artifact size: 394.23 MiB -> 394.31 MiB (0.02%)

petrochenkov · 2026-04-16T08:28:30Z

r? @mu001999
@bors rollup=maybe

mu001999 · 2026-04-16T13:21:43Z

@bors r+

rust-bors · 2026-04-16T13:21:47Z

📌 Commit a50a2e4 has been approved by mu001999

It is now in the queue for this repository.

resolve: Introduce `(Local,Extern)Module` newtypes for local and external modules respectively Right now both `LocalModule` and `ExternModule` refer to the same `ModuleData`, but the module data for local and extern modules can potentially be made quite different, and we can specialize name lookup for both cases as an optimization. Declaration creation for local and external modules was already specialized as a part of the parallel import resolution work (see `define_local` and `define_extern`, rust-lang#145108 and previous PRs), because they have different properties with regards to ownership and synchronization.

…rnal modules respectively

rustbot · 2026-04-17T10:40:05Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-04-17T10:41:40Z

@bors r=mu001999

rust-bors · 2026-04-17T10:41:44Z

📌 Commit 61bc404 has been approved by mu001999

It is now in the queue for this repository.

…uwer Rollup of 5 pull requests Successful merges: - #154781 (Fix attribute order implementation) - #155242 (resolve: Introduce `(Local,Extern)Module` newtypes for local and external modules respectively) - #149614 (Use `MaybeDangling` in `std`) - #153178 (Add `TryFromIntError::kind` method and `IntErrorKind::NotAPowerOfTwo` variant) - #155049 (Documenting the case of `Weak::upgrade` returning `None` when the value behind the reference is missing) Failed merges: - #155308 (Make `OnDuplicate::Error` the default for attributes)

Rollup merge of #155242 - petrochenkov:modmodmod, r=mu001999 resolve: Introduce `(Local,Extern)Module` newtypes for local and external modules respectively Right now both `LocalModule` and `ExternModule` refer to the same `ModuleData`, but the module data for local and extern modules can potentially be made quite different, and we can specialize name lookup for both cases as an optimization. Declaration creation for local and external modules was already specialized as a part of the parallel import resolution work (see `define_local` and `define_extern`, #145108 and previous PRs), because they have different properties with regards to ownership and synchronization.

rustbot assigned jackh726 Apr 13, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 13, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 13, 2026

rust-bors bot pushed a commit that referenced this pull request Apr 13, 2026

Auto merge of #155242 - petrochenkov:modmodmod, r=<try>

64fb35f

resolve: Introduce `(Local,Extern)Module` newtypes for local and external modules respectively

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 13, 2026

rustbot assigned mu001999 and unassigned jackh726 Apr 16, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

JonathanBrouwer mentioned this pull request Apr 16, 2026

Rollup of 15 pull requests #155398

Closed

JonathanBrouwer mentioned this pull request Apr 16, 2026

Rollup of 14 pull requests #155401

Closed

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2026

This comment has been minimized.

Sign in to view

resolve: Introduce (Local,Extern)Module newtypes for local and exte…

61bc404

…rnal modules respectively

petrochenkov force-pushed the modmodmod branch from a50a2e4 to 61bc404 Compare April 17, 2026 10:40

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 17, 2026

JonathanBrouwer mentioned this pull request Apr 17, 2026

Rollup of 5 pull requests #155432

Merged

rust-bors bot merged commit 89bec2c into rust-lang:main Apr 17, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 17, 2026

Uh oh!

Conversation

petrochenkov commented Apr 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

petrochenkov commented Apr 13, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Apr 13, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Apr 13, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

petrochenkov commented Apr 16, 2026

Uh oh!

mu001999 commented Apr 16, 2026

Uh oh!

rust-bors bot commented Apr 16, 2026

Uh oh!

This comment has been minimized.

rustbot commented Apr 17, 2026

Uh oh!

petrochenkov commented Apr 17, 2026

Uh oh!

rust-bors bot commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

petrochenkov commented Apr 13, 2026 •

edited by rustbot

Loading